Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reqwest-retry): Configurable log level for retry event #137

Merged
merged 5 commits into from
Apr 11, 2024
Merged

feat(reqwest-retry): Configurable log level for retry event #137

merged 5 commits into from
Apr 11, 2024

Conversation

Simon089
Copy link
Contributor

@Simon089 Simon089 commented Apr 2, 2024

Allow changing the log level for the retry event.

@Simon089 Simon089 requested a review from a team as a code owner April 2, 2024 00:31
tl-eirik-albrigtsen
tl-eirik-albrigtsen reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@tl-eirik-albrigtsen tl-eirik-albrigtsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible, but nit on impl

reqwest-retry/src/middleware.rs Show resolved Hide resolved
@tl-eirik-albrigtsen tl-eirik-albrigtsen merged commit abdf184 into TrueLayer:main Apr 11, 2024
13 checks passed
@Simon089 Simon089 deleted the retry-configurable-log-level branch April 11, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tl-eirik-albrigtsen tl-eirik-albrigtsen tl-eirik-albrigtsen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simon089 @tl-eirik-albrigtsen