OS-6485 CTF conversion fails with large files

[joyent-automation]

OS-6485 CTF conversion fails with large files

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/3034/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@jasonbking commented at 2017-12-08T16:37:49

Patch Set 2:

(2 comments)

Patch Set 2 code comments

usr/src/lib/libctf/common/ctf_dwarf.c#2608 @jasonbking

I know this is pretty much the original comment and this particular piece code is mostly just moved around, but it confused me a bit.

This function appears to be creating (or really initializing) a single ctf_die_t whose index is cdp->cd_ndie (and is called as we iterate over all the dies). The comment implies (to me at least) that it is what is doing the iterating and creating all of them (when really ctf_dwarf_convert() is what is iterating) -- that it itself has to iterate through to effectively seek to the correct dwarf CU adds to the confusion.

It'd be nice if we could reword the comment to be clearer on what is happening -- maybe something along the lines of 'Initialize cdp for the die at index cdp->cd_ndie. Called as we iterate over all the dies. This is used ....' though I'm not really concerned about the specific text as much as just having it better describe what's going on.

usr/src/lib/libctf/common/ctf_dwarf.c#2646 @jasonbking

nit: VERIFY3S might be nicer here (if it trips, it'll display both values in the abort message)