Added support for sync adapter access. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please provide a short example on how you would use this feature in your app? I suspect |
|
You are right. It should be public static! And you would use it by updateing, deleting and creating from the syncadapter with the uri passed through makeUriFromSyncAdapter. |
|
The test failures seem related to this PR. Please check locally with |
| @@ -142,7 +148,7 @@ public Uri insert(Uri uri, ContentValues values) { | |||
| long rowId = mDatabase.insert(segments.get(0), null, values); | |||
|
|
|||
| if (rowId > -1) { | |||
| getContentResolver().notifyChange(uri, null); | |||
| getContentResolver().notifyChange(uri, null, !uri.getQueryParameter(QUERY_CALLER_IS_SYNC_ADAPTER).equals(PARAM_TRUE)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for sync adapters so that syncToNetwork (in getContentResolver().notifyChange) will default to true but when coming from sync adapter is becomes false by using makeUriFromSyncAdapter.