Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the Peer AI module #172

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Conversation

kandrio
Copy link
Contributor

@kandrio kandrio commented Sep 19, 2023

This PR introduces the Peer AI module of the superapp. All work around Peer AI made by @quintene

@kandrio
Copy link
Contributor Author

kandrio commented Sep 19, 2023

There's a test error that I don't understand currently. Working on it to resolve it

@InvictusRMC
Copy link
Member

/home/runner/work/trustchain-superapp/trustchain-superapp/app/src/main/AndroidManifest.xml: Error: When targeting Android 13 or higher, posting a permission requires holding the POST_NOTIFICATIONS permission (usage from com.bumptech.glide.request.target.NotificationTarget) [NotificationPermission]

Seems to be a permission error. See StackOverflow.

@kandrio
Copy link
Contributor Author

kandrio commented Sep 20, 2023

@InvictusRMC I carefully took a look at the permissions that PeerAI was requesting and I found READ_INTERNAL_STORAGE in this line:

However, after taking a look at the official Android documentation, I saw that there is no such permission as READ_INTERNAL_STORAGE. So I removed it in a small commit and the weird error went away. PeerAI seems to be working just fine.

Maybe @quintene could shed some light here too, but other than that, it seems like we're good to merge

@InvictusRMC InvictusRMC marked this pull request as ready for review September 20, 2023 20:12
@kandrio
Copy link
Contributor Author

kandrio commented Sep 26, 2023

@InvictusRMC Should we merge this?

@InvictusRMC InvictusRMC merged commit 8169773 into Tribler:master Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants