Add IPv8-based listening point adapter #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Ok to test |
ichorid
force-pushed
the
devel
branch
2 times, most recently
from
05b4e29
to
d3917f8
Compare
qstokkink
approved these changes
May 8, 2018
|
@xoriole @egbertbouman @devos50 do any of you want to review this as well? |
|
Would be nice to have some tests or usage code with the endpoints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the IPv8->Dispersy listening adapter. Now, the primary listening endpoint could be implemented by IPv8, which would forward packets to Dispersy.
It is required to enable benefits of having a Twisted-based listening endpoint in Tribler.
The code is a shitty copy-paste from original Dispersy endpoint adapter. But who cares, if it's only be around until we ditch Dispersy completely?
See Tribler/tribler#2548