Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 66 noise #71

Merged
merged 12 commits into from
Nov 7, 2023
Merged

feat: 66 noise #71

merged 12 commits into from
Nov 7, 2023

Conversation

alvarosabu
Copy link
Member

Closes #66

I added @tresjs/leches to the playground and one of the props works but the other BlendFunction is not reactive. I'm not sure if it is a bug on the useEffect or is something done by design (postprocessing package)

I would say would be nice if the blendFunction is changed to create the pass again, but not sure how you are handling this now @Tinoooo

@Tinoooo
Copy link
Contributor

Tinoooo commented Oct 27, 2023

So far, I simply left the blendFunction non-reactive. Unluckily blendMode is readonly. If we decide to recreate the pass on blendMode changes, I'd suggest we do it in a seperate branch/ticket, since this affects other effects too.

playground/src/pages/noise.vue Outdated Show resolved Hide resolved
src/core/effects/Noise.vue Outdated Show resolved Hide resolved
src/core/effects/Noise.vue Show resolved Hide resolved
@alvarosabu alvarosabu merged commit cdb9497 into main Nov 7, 2023
2 checks passed
@Tinoooo Tinoooo deleted the feature/66-noise branch September 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Noise
2 participants