Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MTK sepolicy errors noticed in logcat #23

Open
wants to merge 1 commit into
base: android-13.0
Choose a base branch
from

Conversation

JonnyVR1
Copy link

@JonnyVR1 JonnyVR1 commented Jul 1, 2023

No description provided.

@phhusson
Copy link

phhusson commented Jul 1, 2023

Does it fix anything?

@JonnyVR1
Copy link
Author

JonnyVR1 commented Jul 1, 2023

It fixes log spam, as for anything tangible I am unsure, however, less log spam is good for everyone.

@ponces
Copy link

ponces commented Sep 10, 2023

LGTM

@JonnyVR1
Copy link
Author

@phhusson

@phhusson
Copy link

It doesn't fix anything, so no?

@JonnyVR1
Copy link
Author

It fixes errors that are popping up in logcat, is that not a good thing?

@AndyCGYan
Copy link

As @JonnyVR1 PR'd this to my side a few times, I'd like to piggyback on this original thread, to evaluate if it has a similar risk of rule conflict like this. I certainly don't want to fix log spam only to break boot for some other vendors...

@JonnyVR1
Copy link
Author

The devices I've tested it only fixes things... Its SE policy so for devices it doesn't apply to it does nothing. Hence my frustration with denial on the original PR 😒

@JonnyVR1
Copy link
Author

I'll fix the recurring PR as I maintain my own forks with this in, no issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants