Distributed scan report #63
Conversation
souvik-karfa
requested review from
samarth-gupta-traceable and
dhruv-singhal-github
as code owners
| throw new FileNotFoundException("Temp file not found"); | ||
| } | ||
|
|
||
| this.htmlReport = status[1]; |
There was a problem hiding this comment.
add check status is having size 2 else return No output generated.
There was a problem hiding this comment.
In the GenerateReport FileCallable, I am explicitly making an array of size 2. Is the size 2 check necessary then? I can check for null value.
| @@ -12,6 +12,10 @@ | |||
| import hudson.util.Secret; | |||
| import io.jenkins.plugins.traceable.ast.scan.helper.Assets; | |||
| import io.jenkins.plugins.traceable.ast.scan.helper.TrafficType; | |||
| import java.io.*; | |||
There was a problem hiding this comment.
can we import specific package
| throw new FileNotFoundException("Temp file not found"); | ||
| } | ||
|
|
||
| this.htmlReport = status[1]; |
There was a problem hiding this comment.
put in else.
| if (reportCmdExitValue == 4) { | ||
| String[] status = this.workspace.act(new GenerateReport(scriptPath, args, run.getId())); | ||
|
|
||
| if (status[0].equals("FAILURE")) { |
There was a problem hiding this comment.
check if status is having size >0
There was a problem hiding this comment.
Same as before, we are explicitly declaring an array of size 2. Also the value of processExitValue is SUCCESS by default. So it will never be null. It will either be SUCCESS or FAILURE
There was a problem hiding this comment.
yes, it's always better to put the check if we are not having unit tests.
Summary:
GenerateScanReportAction.<pre>tag to maintain the formatting of the text.