-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Diagonal Operator #1578
Draft
MargaretDuff
wants to merge
6
commits into
TomographicImaging:master
Choose a base branch
from
MargaretDuff:blockdiagonaloperator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Block Diagonal Operator #1578
MargaretDuff
wants to merge
6
commits into
TomographicImaging:master
from
MargaretDuff:blockdiagonaloperator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some open questions:
|
@jakobsj You mentioned that you had thought about this before - any thoughts? |
I think this could also be handled by For instance this CIL/Wrappers/Python/cil/optimisation/operators/BlockOperator.py Lines 206 to 207 in 524d403
could be substituted by op = self.get_item(row, col)
if not isinstance(op, ZeroOperator):
prod += op.direct(x_b.get_item(col)) |
casperdcl
force-pushed
the
master
branch
3 times, most recently
from
September 2, 2024 13:11
a910556
to
f8b513b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Takes in a main diagonal, a list of operators, and, optionally, other diagonals and creates an BlockDiagonalOperator that subclasses the operator class.
Describe any testing you have performed
Please add any demo scripts to CIL-Demos/misc/
Link relevant issues
Closes #1568
Checklist when you are ready to request a review
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.