BlockOperator: added a function to return a list of norms and the ability to set this list of norms #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MargaretDuff
changed the title
|
P.s. It might be worth thinking about issue #1484 at the same time or instead leaving it as a separate PR? |
gfardell
reviewed
Oct 5, 2023
gfardell
requested changes
Oct 5, 2023
paskino
requested changes
Oct 6, 2023
Signed-off-by: Margaret Duff <[email protected]>
paskino
reviewed
Oct 17, 2023
paskino
reviewed
Oct 17, 2023
paskino
reviewed
Oct 17, 2023
paskino
reviewed
Oct 17, 2023
paskino
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Apart for one suggestion of a docstring and removal of an old commented piece of code, it looks good to me.
Please do open issues as per comments.
https://github.com/TomographicImaging/CIL/pull/1513/files#r1362075817
https://github.com/TomographicImaging/CIL/pull/1513/files#r1362089405
MargaretDuff
added
the
Merge pending jenkins
8 tasks
MargaretDuff
commented
Oct 31, 2023
MargaretDuff
commented
Oct 31, 2023
…garet into blockoperator-norms
gfardell
requested changes
Nov 6, 2023
gfardell
reviewed
Nov 7, 2023
gfardell
approved these changes
Nov 7, 2023
Co-authored-by: Gemma Fardell <[email protected]> Signed-off-by: Margaret Duff <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
BlockOperator.norms() lists the norms of each individual operator in the block, using the operator functions to either call the cached value or calculate it and cache the value. BlockOperator.set_norms() uses the set_norm function of each individual operator to set the cached value of the norm of the underlying operators.
Relevant unit tests have been added.
Describe any testing you have performed
Link relevant issues
Closes #1510
Checklist when you are ready to request a review
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.