Skip to content

Commit

Permalink
Debug because I don't have PGSQL locally
Browse files Browse the repository at this point in the history
  • Loading branch information
Tofandel committed Jan 26, 2024
1 parent edf3565 commit 1be71c6
Showing 1 changed file with 21 additions and 17 deletions.
38 changes: 21 additions & 17 deletions tests/Functional/Platform/RenameColumnTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Doctrine\DBAL\Tests\FunctionalTestCase;
use Doctrine\DBAL\Types\Type;
use Doctrine\DBAL\Types\Types;
use Throwable;

use function var_dump;

Expand Down Expand Up @@ -43,29 +44,32 @@ public function testColumnPositionRetainedAfterImplicitRenaming(string $columnNa
/** @dataProvider columnNameProvider */
public function testColumnPositionRetainedAfterExplicitRenaming(string $columnName, string $newColumnName): void
{
$table = new Table('test_rename');
$table->addColumn($columnName, Types::INTEGER, ['length' => 16]);
$table->addColumn('c2', Types::INTEGER);
$table = new Table('test_rename');
$table->addColumn($columnName, Types::INTEGER, ['length' => 16]);
$table->addColumn('c2', Types::INTEGER);

$this->dropAndCreateTable($table);
$this->dropAndCreateTable($table);

// Force a different type to make sure it's not being caught implicitly
$table->renameColumn($columnName, $newColumnName)->setType(Type::getType(Types::BIGINT))->setLength(32);
// Force a different type to make sure it's not being caught implicitly
$table->renameColumn($columnName, $newColumnName)->setType(Type::getType(Types::BIGINT))->setLength(32);

$sm = $this->connection->createSchemaManager();
$diff = $sm->createComparator()
->compareTables($sm->introspectTable('test_rename'), $table);
$sm = $this->connection->createSchemaManager();
$diff = $sm->createComparator()
->compareTables($sm->introspectTable('test_rename'), $table);

var_dump($this->connection->getDatabasePlatform()->getAlterTableSQL($diff));
$sm->alterTable($diff);
try {
$sm->alterTable($diff);

$table = $sm->introspectTable('test_rename');
$columns = $table->getColumns();
$table = $sm->introspectTable('test_rename');
$columns = $table->getColumns();

self::assertCount(1, $diff->getChangedColumns());
self::assertCount(2, $columns);
self::assertEqualsIgnoringCase($newColumnName, $columns[0]->getName());
self::assertEqualsIgnoringCase('c2', $columns[1]->getName());
self::assertCount(1, $diff->getChangedColumns());
self::assertCount(2, $columns);
self::assertEqualsIgnoringCase($newColumnName, $columns[0]->getName());
self::assertEqualsIgnoringCase('c2', $columns[1]->getName());
} catch (Throwable) {
var_dump($this->connection->getDatabasePlatform()->getAlterTableSQL($diff));

Check failure on line 71 in tests/Functional/Platform/RenameColumnTest.php

View workflow job for this annotation

GitHub Actions / Static Analysis with Psalm (8.2)

ForbiddenCode

tests/Functional/Platform/RenameColumnTest.php:71:13: ForbiddenCode: Unsafe var_dump (see https://psalm.dev/002)
}
}

/** @return iterable<array{string,string}> */
Expand Down

0 comments on commit 1be71c6

Please sign in to comment.