Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Need Help Testing] Implement gthread worker #61

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

wooparadog
Copy link
Member

@wooparadog wooparadog commented Jan 10, 2019

Help Needed

This pull request has been stalled for quite some time because we can't
find an environment to battle test it.

Any help reguarding testing is greatly appreciated.

Dev progress:

Working in progress... 🚧

  • implementation
  • unit tests
  • manual tests
  • documentations

Requests:

#53 #52 Thriftpy/thriftpy2#29

@ethe
Copy link
Member

ethe commented Mar 15, 2019

Can we merge it to fix the failing of CI in the master branch?

@wooparadog
Copy link
Member Author

@ethe I'm not so sure, in my opinion, it needs more testing before it could be merged. (Needs battle proving)

@ethe
Copy link
Member

ethe commented Mar 27, 2019

I have already cherry picked some commit in this pull request to solve current CI problems.

@victordudu1121
Copy link

@wooparadog @ethe
我们的某些业务场景必须使用Tframedtransport, 所以能否烦请 @wooparadog 帮确认,gthread worker 是否支持transport为Tframedtransport类型?我们可以进行实践测试!
多谢, 多谢!

@wooparadog
Copy link
Member Author

@victordudu1121 抱歉回复晚了。按照道理上讲, worker 类型和 transport 无关的。 这个 PR 一直没合的原因是其一这个没有在什么地方能够 battle prove 不敢合,其二我最近抽不出时间来测试这个。

@victordudu1121
Copy link

@victordudu1121 抱歉回复晚了。按照道理上讲, worker 类型和 transport 无关的。 这个 PR 一直没合的原因是其一这个没有在什么地方能够 battle prove 不敢合,其二我最近抽不出时间来测试这个。

@wooparadog 之前从@ethe 处回复得知worker-class=thriftpy_gevent 必须 配合如下transport使用,不支持transport=TFramedtrasnport, 我们的服务既需要TBuffertrasnport, 又需要TFramedtransport, 所以在使用transport=TFramedtrasnport的情况下,为了提高基于thriftpy2实现的server的并发处理能
力, 想采用你实现的gthread Worker !
image

@ethe
Copy link
Member

ethe commented Jul 16, 2019

Hmmm Gevent 应该是可以和 TFramedTransport 一起用的,这两者之间没有什么关联。。

@wooparadog wooparadog changed the title [WIP] Implement gthread worker [Need Help Testing] Implement gthread worker Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants