Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Docker Compose Setup and Test Execution Script #28

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hackintoshrao
Copy link
Contributor

This pull request introduces a comprehensive Docker Compose setup for our application and a corresponding shell script to manage the execution of tests.

The key changes include:

  1. Creation of a docker-compose.yml file:

This file defines two services: qdrant and tests.
The qdrant service is configured to use the qdrant/qdrant image and exposes the necessary ports.
The tests service is configured to use the rust:1.55 image and runs the test command in the appropriate working directory. It also depends on the qdrant service being healthy before starting.

  1. Creation of a shell script for test execution
    The script checks for the presence of Docker and Docker Compose.
    It navigates to the directory containing the docker-compose.yml file.
    It accepts an optional --build flag. If provided, the script rebuilds the Docker images before starting the services and running the tests.

It starts the Docker Compose services, runs the tests, and then tears down the services.
These changes allow for a streamlined and flexible testing process, making it easier to incorporate code changes and manage the lifecycle of the services involved in testing.

Please review these changes and provide any feedback.

@hackintoshrao
Copy link
Contributor Author

Fixes #22

Copy link
Contributor

@kvey kvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, I've noted an organizational change to where the script is, if that change could be made, then this is ready.

@@ -0,0 +1,28 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better located in /toolchain/scripts for consistency, and could be named run_qdrant_tests.sh. The other scripts there have a pattern for executing from the root of the repo as their cwd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants