Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some class components to functional #6712

Merged
merged 13 commits into from
Nov 23, 2023

Conversation

PavelJankoski
Copy link
Contributor

@PavelJankoski PavelJankoski commented Nov 16, 2023

Summary

References #6376

Changes

List of refactored components:

  • /pkg/webui/components/form/field/stories/shared.js
  • /pkg/webui/components/input/stories/shared.js
  • /pkg/webui/components/profile-dropdown/index.js
  • /pkg/webui/components/breadcrumbs/context.js
  • /pkg/webui/components/tag/group/index.js
  • /pkg/webui/lib/components/date-time/index.js
  • /pkg/webui/lib/components/animation/index.js
  • /pkg/webui/lib/components/env.js
  • /pkg/webui/lib/errors/custom-errors.js -> not a component
  • /pkg/webui/lib/yup.js -> not a component
  • /pkg/webui/console/components/webhook-template-form/index.js
  • /pkg/webui/console/components/webhook-form/index.js
  • /pkg/webui/console/components/pubsub-form/index.js
  • /pkg/webui/console/components/events/error-boundary.js
  • /pkg/webui/console/components/location-form/index.js
  • /pkg/webui/console/components/join-eui-prefixes-input/index.js - removed
  • /pkg/webui/console/containers/gateway-connection/gateway-connection.js

Notes for Reviewers

When testing, please pay more attention to the refactored form components because they are large and you know the business logic more briefly(if everything behaves as expected).

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added the ui/web This is related to a web interface label Nov 16, 2023
@PavelJankoski PavelJankoski self-assigned this Nov 16, 2023
@PavelJankoski PavelJankoski changed the title Refactor and turn class components into functional components Refactor some class components to functional Nov 20, 2023
@PavelJankoski PavelJankoski marked this pull request as ready for review November 20, 2023 12:39
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and a lot of changes indeed. Let's see what the e2es say.
I've found some minor issues.

pkg/webui/console/components/location-form/index.js Outdated Show resolved Hide resolved
pkg/webui/console/components/location-form/index.js Outdated Show resolved Hide resolved
pkg/webui/lib/components/env.js Outdated Show resolved Hide resolved
@kschiffer
Copy link
Contributor

@ryaplots please take a look as well

Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just a small issue with the pubsub form according to the e2e tests.

See my remark.

Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please clean up the commit trail before merging. Any fix commits should be squashed into their respective earlier commit. You can use interactive rebasing to achieve that.

@PavelJankoski PavelJankoski requested a review from a team as a code owner November 23, 2023 11:26
@PavelJankoski PavelJankoski merged commit 8b1c55c into v3.28 Nov 23, 2023
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the fix/remove-class-components branch November 23, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants