Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #6403, the lack of a message sent to the channel implies in the telemetry always timing out.
Changes
telemetrySubmission <- struct{}{}
Testing
Manual tests, also confirmed that the CLI interacts with the telemetry collector properly and that it shows on the Grafana dashboard.
Notes for Reviewers
I noticed that when deleting the telemetry's cache file I got a timeout even with a second delay, I believe its due to the initial creation of the telemetry cache file and the yaml parsing involved in that:
All subsequent send operations are within the time window (1s) regardless if its on a SSD or a normal hard drive, which shouldn't make a difference since the time window is so large. I'm thinking that the parsing is the main culprit for the slowdown, even if the data is quite small.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.