Merge pull request #6333 from TheThingsNetwork/fix/js-sdk-delete-query

Send DELETE payload as search parameters for delete requests in JS SDK

CHANGELOG.md

@@ -21,6 +21,7 @@ For details about compatibility between different releases, see the **Commitment
 
 ### Fixed
 
+- Removing user invitations not working in the user management panel for administrators.
 - Fix payload formatter page launching malformed requests in the Console.
 - HTTP API routes for parsing QR codes for the QR Generator service. We exercise our right to break compatibility with third party HTTP clients since this is a bug.
   - `/qr-code/end-devices/parse` is changed to `/qr-codes/end-devices/parse`.

cypress/integration/console/devices/unclaim.spec.js

@@ -73,7 +73,7 @@ describe('Device un-claiming', () => {
   })
 
   it('succeeds un-claiming and deleting an end device', () => {
-    cy.intercept('DELETE', `/api/v3/edcs/claim/${appId}/devices/${endDeviceId}`, {}).as(
+    cy.intercept('DELETE', `/api/v3/edcs/claim/${appId}/devices/${endDeviceId}?*`, {}).as(
       'unclaim-request',
     )
 
@@ -86,10 +86,14 @@ describe('Device un-claiming', () => {
         cy.findByRole('button', { name: /Unclaim and delete end device/ }).click()
       })
 
-    cy.wait('@unclaim-request').its('request.body').should('deep.equal', {
-      dev_eui: ns.end_device.ids.dev_eui,
-      join_eui: '0000000000000000',
-    })
+    cy.wait('@unclaim-request')
+      .its('request.url')
+      .then(url => {
+        const params = new URLSearchParams(new URL(url).search)
+
+        expect(params.get('dev_eui')).to.equal(ns.end_device.ids.dev_eui)
+        expect(params.get('join_eui')).to.equal('0000000000000000')
+      })
 
     cy.findByTestId('error-notification').should('not.exist')
 

sdk/js/src/api/http.js

@@ -108,7 +108,7 @@ class Http {
         url: endpoint,
       }
 
-      if (method === 'get') {
+      if (method === 'get' || method === 'delete') {
         // For GETs convert payload to query params (should usually
         // be field_mask only).
         config.params = this._payloadToQueryParams(payload)