Prioritize gateway's field contacts over Contact Info list #5595
nicholaspcrgo.yml
on: pull_request
Code Quality
7m 17s
Tests
11m 23s
Annotations
7 errors and 3 warnings
|
Code Quality:
pkg/packetbrokeragent/agent_test.go#L87
Error return value of `(*go.thethings.network/lorawan-stack/v3/pkg/identityserver/mock.mockISUserRegistry).Create` is not checked (errcheck)
|
|
Code Quality:
pkg/packetbrokeragent/agent_test.go#L90
Error return value of `(*go.thethings.network/lorawan-stack/v3/pkg/identityserver/mock.mockISUserRegistry).Create` is not checked (errcheck)
|
|
Code Quality:
pkg/packetbrokeragent/agent_test.go#L93
Error return value of `(*go.thethings.network/lorawan-stack/v3/pkg/identityserver/mock.mockISOrganizationRegistry).Create` is not checked (errcheck)
|
|
Code Quality:
pkg/packetbrokeragent/grpc_gspba.go#L109
cyclomatic complexity 32 of func `(*gsPbaServer).UpdateGateway` is high (> 20) (gocyclo)
|
|
Code Quality:
pkg/packetbrokeragent/is.go#L28
Sentence should start with a capital letter (godot)
|
|
Code Quality:
pkg/packetbrokeragent/is.go#L15
ST1000: at least one file in a package should have a package comment (stylecheck)
|
|
Code Quality
issues found
|
|
Code Quality:
pkg/identityserver/mock/mock.go#L105
unexported-return: exported method OrganizationRegistry returns unexported type *mockis.mockISOrganizationRegistry, which can be annoying to use (revive)
|
|
Code Quality:
pkg/identityserver/mock/mock.go#L110
unexported-return: exported method UserRegistry returns unexported type *mockis.mockISUserRegistry, which can be annoying to use (revive)
|
|
Code Quality:
pkg/packetbrokeragent/grpc_gspba.go#L182
empty-lines: extra empty line at the end of a block (revive)
|