Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CubicMeter 1.1 normalized output and schema update #828

Conversation

peter-quandify
Copy link
Contributor

Summary

Updated the decoder property and bug fix for Quandify CubicMeter 1.1
Added schema to support normalized output for metering and water temperature

Changes

  • Renamed decoded data member leakStatus to leakState
  • Fixed rounding issue for temperature calculation
  • Added schema for metering
  • Added schema for water temperature

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

Extended water schema to include temperature.
The min, max, avg, current was added to allow for different types of devices and sampling rates.
Our device samples once a second and can therefore show more values than a sensor that samples just before sending.

Added metering schema which could be extended for electricity and gas in the future.

Would be interesting to investigate JSON schema 2020-12 generic types in the future.
This could bring a generalised structure for all measurements where sampling is done multiple times between uplinks.
This would require all current measurements to migrate to the "current" property.

Release Notes

@Jaime-Trinidad
Copy link
Contributor

Hi @peter-quandify everything looks good, can you update the PR after 17h, so I can merge it. Thank you

@peter-quandify peter-quandify force-pushed the quandify/normalized-schema-update branch from da9e220 to e80d9af Compare October 10, 2024 14:05
@Jaime-Trinidad Jaime-Trinidad merged commit 0480f99 into TheThingsNetwork:master Oct 10, 2024
2 checks passed
@peter-quandify peter-quandify deleted the quandify/normalized-schema-update branch October 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants