Extend normalized payload #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendor/milesight-iot/ws301.js
Outdated
| @@ -49,7 +49,7 @@ function normalizeUplink(input) { | |||
| return { | |||
| data: { | |||
| action: { | |||
| contactState: input.data.door.toUpperCase() | |||
| contactState: input.data.door ? "OPEN":"CLOSED" | |||
There was a problem hiding this comment.
So is it a boolean? Before you assumed it was a string?
There was a problem hiding this comment.
Yeah i think so, im basically copying what is used above:
There was a problem hiding this comment.
So in this case input.data.door is either close or open. Not CLOSE or OPEN and not a boolean.
To convert close or open to CLOSED or OPEN respectively, you need to contactState: input.data.door === "close" ? "CLOSED" : input.data.door === "open ? "OPEN" : undefined
There was a problem hiding this comment.
I finally see how it should work now, apologies.
johanstokking
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extend the normalized payload function to 20 devices.
Changes
Checklist for Reviewers
profileIDsshould not bevendorIDand should be a unique value for every profile.index.yamlfile.