-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setup script #693
Add a setup script #693
Conversation
@johanstokking can you take a look to @LDannijs work here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
To avoid duplication can you call the setup devices script from the setup script? You can pass the vendor ID as argument so you can skip that prompt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Few more things:
- Add line breaks before 80 characters (that is the max line length)
- Respect
NO_COLOR
environment variable. If set, don't print colors. Not all terminals are able to show them and so it becomes an unreadable mess. You can keep the assignments but make sure they're empty whenNO_COLOR
is set
Would I need to do this for only the echo commands or the entire code? |
Ideally both but certainly anything printed. |
I hope the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Jaime-Trinidad did you test this locally? |
Yes, there are some fixes to do: Codec: Profile: Index: |
d3aee32
to
29682c7
Compare
(apologies for messing up the commit history. There were commits from a different branch that i had accidentally been using on here, so i tried to fix it 😓. Need to learn to double check these things) |
2931ed0
to
aeaf825
Compare
So few changes made:
|
Please ping @Jaime-Trinidad to review and test. |
Did a few things:
|
Turned the command to run the script into a make command to match the other commands. And with #736 now being merged i can reopen this PR. |
Summary
At the moment, users are required to create a bunch of files containing boilerplate code that they then need to edit whenever they want to add a vendor or new devices. This PR add 2 scripts that create all of the files by just entering a few questions. I'd like to receive feedback on what other changes could be made to improve it.
This is an in between feature, idea is that eventually a type of form will be used for the repo, but for now this should at least be helpful.
(recreated this PR cause i had some organizing of my fork)
Changes
Preview of what the scripts look like.