Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ttui-header and ttui-footer #1265

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mjamescompton
Copy link
Contributor

@mjamescompton mjamescompton commented Feb 9, 2024

Summary

Include ttui-header and ttui-footer

Screenshots

Screen.Recording.2024-02-08.at.16.28.29.mov

Changes

  • Replace header with ttui-header
  • Update some page styling and the search input
  • Replace footer with ttui-footer

Notes for Reviewers

To run this locally you will need to run yarn link and be running yarn watch-linked on this branch of the design repository https://github.com/TheThingsIndustries/design/pull/216

In this repo cd docs and yarn link @tti/design.

For some reason this does not work with the minified js, for now in the this commit
util: TEMPORARY remove js minify for yarn link I remove the js minify, we should put this back for deployment

You can then run the project as normal with make

@KrishnaIyer there is a screen size where there is to much in the menu, maybe we could organise this into dropdown for desktop?

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@mjamescompton mjamescompton self-assigned this Feb 9, 2024
@PavelJankoski PavelJankoski added this to the Mar 2024 milestone Mar 1, 2024
@nejraselimovic
Copy link
Contributor

hey @mjamescompton, can you pls tag someone to review this?

@KrishnaIyer KrishnaIyer self-requested a review March 27, 2024 13:25
Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To run this locally you will need to run yarn link and be running yarn watch-linked on this branch of the design repository https://github.com/TheThingsIndustries/design/pull/216

So the new TTUI version cannot be pulled using make js.deps?

@KrishnaIyer there is a screen size where there is to much in the menu, maybe we could organise this into dropdown for desktop?

Can you elaborate?

doc/config/_default/config.toml Outdated Show resolved Hide resolved
@KrishnaIyer KrishnaIyer removed this from the Mar 2024 milestone Apr 4, 2024
@mjamescompton
Copy link
Contributor Author

To run this locally you will need to run yarn link and be running yarn watch-linked on this branch of the design repository TheThingsIndustries/design#216

So the new TTUI version cannot be pulled using make js.deps?

@KrishnaIyer there is a screen size where there is to much in the menu, maybe we could organise this into dropdown for desktop?

Can you elaborate?

This how you can use your local ttui with your local web project. It telling yarn that the location of the ttui package is not from the remote path but the node_modules contains an alias to local path.

https://classic.yarnpkg.com/lang/en/docs/cli/link/

Once we have released the design repo you can update the version number of ttui and make js.deps will get the latest

@KrishnaIyer
Copy link
Contributor

Ok I see. Then let's wait for the TTUI release and then check this. We don't want to merge this accidentally before that and break CI.

@KrishnaIyer
Copy link
Contributor

@mjamescompton I've rebased this and the content looks fine. Can you remove the temporary commits so we can get this out?

@PavelJankoski PavelJankoski changed the title Add ttui-header Add ttui-header and ttui-footer Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants