-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ttui-header and ttui-footer #1265
base: master
Are you sure you want to change the base?
Conversation
hey @mjamescompton, can you pls tag someone to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To run this locally you will need to run yarn link and be running yarn watch-linked on this branch of the design repository https://github.com/TheThingsIndustries/design/pull/216
So the new TTUI version cannot be pulled using make js.deps
?
@KrishnaIyer there is a screen size where there is to much in the menu, maybe we could organise this into dropdown for desktop?
Can you elaborate?
This how you can use your local ttui with your local web project. It telling yarn that the location of the ttui package is not from the remote path but the node_modules contains an alias to local path. https://classic.yarnpkg.com/lang/en/docs/cli/link/ Once we have released the design repo you can update the version number of ttui and |
Ok I see. Then let's wait for the TTUI release and then check this. We don't want to merge this accidentally before that and break CI. |
ae1a881
to
0f9922d
Compare
@mjamescompton I've rebased this and the content looks fine. Can you remove the temporary commits so we can get this out? |
Summary
Include ttui-header and ttui-footer
Screenshots
Screen.Recording.2024-02-08.at.16.28.29.mov
Changes
Notes for Reviewers
To run this locally you will need to run
yarn link
and be runningyarn watch-linked
on this branch of the design repository https://github.com/TheThingsIndustries/design/pull/216In this repo
cd docs
andyarn link @tti/design
.For some reason this does not work with the minified js, for now in the this commit
util: TEMPORARY remove js minify for yarn link I remove the js minify, we should put this back for deployment
You can then run the project as normal with
make
@KrishnaIyer there is a screen size where there is to much in the menu, maybe we could organise this into dropdown for desktop?
Checklist
make server
, posted screenshots, verified external links. Test withHUGO_PARAMS_SEARCH_ENABLED=true
if style changes will affect the search bar.new-in-version
shortcode, according to the guidelines in CONTRIBUTING.