Improve _preprocess_name to replace % and # with letters

src/polish_names.jl

@@ -44,7 +44,7 @@ Return a vector of symbols containing new names that are unique and formated usi
 """
 function generate_polished_names(names; style::Symbol=:snake_case)
     names = _preprocess_name.(names)
-    
+
     return generate_polished_names(names, Style(style))
 end
 
@@ -79,13 +79,15 @@ function generate_polished_names(names, ::Style)
 end
 
 function _preprocess_name(name)
-    preprocessed = normalize(String(name), stripmark=true)
+    preprocessed = normalize(String(name); stripmark=true)
 
-    matched = match(r"^[[:upper:]]+$", preprocessed)
+    matched = match(r"^[[:upper:]]+|\%|\#$", preprocessed)
     if matched !== nothing
-        return lowercase(preprocessed)
+        preprocessed = lowercase(preprocessed)
     end
 
+    preprocessed = replace(preprocessed, "%" => "Percent", "#" => "Number")
+
     return preprocessed
 end
 

test/test_polish_names.jl

@@ -34,6 +34,8 @@ using DataFrames: DataFrame
             "  _aName with_loTsOfProblems_1",
             "  _aName with_loTsOfProblems_1_a/b'c",
             "ID",
+            "NOËL%",
+            "NOEL #",
         ];
         style=:snake_case,
     ) == Vector{Symbol}([
@@ -42,6 +44,8 @@ using DataFrames: DataFrame
         :a_name_with_lo_ts_of_problems_1_1,
         :a_name_with_lo_ts_of_problems_1_a_b_c,
         :id,
+        :noel_percent,
+        :noel_number,
     ])
 
     @test generate_polished_names(
@@ -52,6 +56,8 @@ using DataFrames: DataFrame
             "  _aNameABC with_loTsOfProblemsDEF",
             "  _aNameABC with_loTsOfProblemsDEF_a/b'c",
             "ID",
+            "NOËL%",
+            "NOEL #",
         ];
         style=:camelCase,
     ) == Vector{Symbol}([
@@ -61,6 +67,8 @@ using DataFrames: DataFrame
         :aNameABCWithLoTsOfProblemsDEF,
         :aNameABCWithLoTsOfProblemsDEFABC,
         :id,
+        :noelPercent,
+        :noelNumber,
     ])
 
     let err = nothing