fix regression for title case names

TheRoniOne · Jun 7, 2024 · 6f90013 · 6f90013
1 parent 08e5d95
commit 6f90013
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/polish_names.jl b/src/polish_names.jl
@@ -81,7 +81,7 @@ end
 function _preprocess_name(name)
     preprocessed = normalize(String(name); stripmark=true)
 
-    matched = match(r"^[[:upper:]]+|\%|\#$", preprocessed)
+    matched = match(r"^[[:upper:]\%\#\s]+$", preprocessed)
     if matched !== nothing
         preprocessed = lowercase(preprocessed)
     end

diff --git a/test/test_polish_names.jl b/test/test_polish_names.jl
@@ -8,6 +8,7 @@ using DataFrames: DataFrame
         "  _aName with_loTsOfProblems1" => [4, 5, 6],
         "  _aName with_loTsOfProblems2" => [7, 8, 9],
         "  _aNameABC with_loTsOfProblemsDEF" => [10, 11, 12],
+        "ImTitleCase" => [13, 14, 15],
     )
     testCT = CleanTable(testDF)
 
@@ -16,13 +17,15 @@ using DataFrames: DataFrame
         :a_name_with_lo_ts_of_problems1,
         :a_name_with_lo_ts_of_problems2,
         :a_name_abc_with_lo_ts_of_problems_def,
+        :im_title_case,
     ])
 
     @test names(polish_names!(testCT; style=:camelCase)) == Vector{Symbol}([
         :aNameWithLoTsOfProblems,
         :aNameWithLoTsOfProblems1,
         :aNameWithLoTsOfProblems2,
         :aNameAbcWithLoTsOfProblemsDef,
+        :imTitleCase,
     ])
 
     @test polish_names(testDF) isa CleanTable