Update to 1.17 and rework Autoconfig to use Jankson #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koelle25
reviewed
Aug 22, 2021
| addGameVersion "1.16.2" | ||
| addGameVersion "1.16.1" | ||
| addGameVersion "Java 16" | ||
| addGameVersion "1.17.0" |
There was a problem hiding this comment.
I think it should be
addGameVersion "1.17.1"
addGameVersion "1.17"
instead of 1.17.0
| addGameVersion("1.16.3") | ||
| addGameVersion("1.16.2") | ||
| addGameVersion("1.16.1") | ||
| addGameVersion("1.17.0") |
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.1-bin.zip | |||
There was a problem hiding this comment.
You could update to Gradle 7.2 (released a few days ago)
koelle25
reviewed
Aug 22, 2021
build.gradle
Outdated
| @@ -2,28 +2,27 @@ import com.modrinth.minotaur.TaskModrinthUpload | |||
|
|
|||
| plugins { | |||
| id "java-library" | |||
| id "fabric-loom" version "0.5-SNAPSHOT" | |||
| id "fabric-loom" version "0.8-SNAPSHOT" | |||
There was a problem hiding this comment.
According to https://fabricmc.net/versions.html "The recommended loom version for Minecraft 1.17 is 0.9.+", so:
id "fabric-loom" version "0.9.+".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent some time updating this mod to work on 1.17, currently as far as I can tell it works as intended. The biggest change I made was to switch the AutoConfig to use the built in JSON serializer instead of the custom TOML one, (And split the subclasses of the config into a file called 'config', though that could be reverted if desired) and I also have a custom version of Common Gradle which I updated slightly to point to the latest versions of ModMenu and ClothConfig. (Currently the repo for ModMenu is temporary while they fix issues with their permanent repo, so that would have to change in future)
I also replaced the removed
getUnloadedBlockEntitieswith a call to check if theentity.isRemoved()to determine if the death chest has been removed or unloaded.