Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ZAP package #401

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat: add ZAP package #401

wants to merge 3 commits into from

Conversation

noahfraiture
Copy link

This is a remake of #390, I though it was ok but wrong branch and unsigned, it was thus easier to remake a new branch. Sorry for the wait, I didn't notice the requirement for the sign on the commit

Description

This PR add Zed Attack Proxy as requested in this #381 .

This is my first PR here and I did not succeed to test. When trying to exegol install local I got stuck at [*] Step 14/24 : RUN ./entrypoint.sh package_base
It should work since the PR is very small but if someone can confirm before a merge, it would be great

@QU35T-code QU35T-code self-assigned this Oct 18, 2024
@QU35T-code QU35T-code added new tool(s) This adds one or multiple tools to Exegol under review Time to think about the need / implementation labels Oct 18, 2024
QU35T-code
QU35T-code requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@QU35T-code QU35T-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @noahfraiture,

Thanks for taking the time to suggest this addition !

sources/install/package_web.sh Outdated Show resolved Hide resolved
@QU35T-code QU35T-code added the waiting for additional changes Further changes are requested label Oct 18, 2024
QU35T-code
QU35T-code requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@QU35T-code QU35T-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last modifications and all should be good !

sources/install/package_web.sh Outdated Show resolved Hide resolved
sources/install/package_web.sh Outdated Show resolved Hide resolved
@QU35T-code
Copy link
Member

Also, can you clean the /tmp dir ? rm -rf /tmp/ZAP_${zap_version} and rm /tmp/zap.tar.gz

@noahfraiture
Copy link
Author

Yep done

@QU35T-code QU35T-code linked an issue Oct 19, 2024 that may be closed by this pull request
Add ZAP (zed attack proxy) #381
Open
QU35T-code
QU35T-code requested changes Oct 20, 2024
View reviewed changes
sources/install/package_web.sh Outdated Show resolved Hide resolved
QU35T-code
QU35T-code requested changes Oct 21, 2024
View reviewed changes
sources/install/package_web.sh Outdated Show resolved Hide resolved
QU35T-code
QU35T-code requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@QU35T-code QU35T-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last changes ! :)

sources/install/package_web.sh Outdated Show resolved Hide resolved
@QU35T-code QU35T-code added waiting for review A review is requested and removed waiting for additional changes Further changes are requested labels Oct 21, 2024
@ShutdownRepo ShutdownRepo added waiting for additional changes Further changes are requested and removed waiting for review A review is requested under review Time to think about the need / implementation labels Oct 23, 2024
@QU35T-code QU35T-code added waiting for review A review is requested under review Time to think about the need / implementation labels Nov 6, 2024
@QU35T-code QU35T-code self-requested a review November 6, 2024 21:18
@QU35T-code QU35T-code added ready for merge in the waitlist for merge, requires preliminary steps and removed waiting for review A review is requested labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShutdownRepo ShutdownRepo ShutdownRepo requested changes

@QU35T-code QU35T-code QU35T-code approved these changes

Assignees

@QU35T-code QU35T-code

Labels
new tool(s) This adds one or multiple tools to Exegol ready for merge in the waitlist for merge, requires preliminary steps under review Time to think about the need / implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ZAP (zed attack proxy)
3 participants
@noahfraiture @QU35T-code @ShutdownRepo