Fix binwalk dependencies #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShutdownRepo
requested changes
May 14, 2024
There was a problem hiding this comment.
Do you mind importing the changes from #347 in this PR? So that we avoid conflicts
ShutdownRepo
added
waiting for additional changes
bugfix
ShutdownRepo
approved these changes
May 15, 2024
QU35T-code
requested changes
Jun 3, 2024
QU35T-code
approved these changes
Jun 4, 2024
|
Thx @lap1nou ! |
QU35T-code
added
ready for merge
QU35T-code
removed
the
ready for merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Greetings,
When running something along the line of:
binwalk -e test.sqhfs --run-as=root, I get:The
unsquashfsdependency is not installed, this PR aim to fix that, it also move the binwalk install in it's own install function.Related issues
N/A
Point of attention
Binwalk list other dependency such as
sasquatch(https://github.com/ReFirmLabs/binwalk/blob/master/INSTALL.md), since I haven't encountered a case where those were needed I propose to add them later on if necessary.