Do not have Properties write their own IDs #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously each prop wrote their own id into the buffer, but did not _read_ it. This asymmetry is not great and this patch fixes it. However, UserProperties is different, so it still writes ids for _subsequent_ packets... Nothing much to be done there. Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
|
As you allowed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously each prop wrote their own id into the buffer, but did not read it.
This asymmetry is not great and this patch fixes it.
However, UserProperties is different, so it still writes ids for subsequent packets... Nothing much to be done there.