Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: test against LLVM 18.1 #525

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

airwoodix
Copy link
Contributor

@airwoodix airwoodix commented Aug 19, 2024

Description

Add a matrix entry for LLVM 18.1 in the testing workflow.

Requires updating to KyleMayes/install-llvm-action v2.0.2+. Breaking API changes from v2.0.0 are not relevant here.

Related Issue

#482, #524 (comment)

How This Has Been Tested

Checklist

@TheDan64 TheDan64 self-requested a review August 19, 2024 14:03
@TheDan64 TheDan64 assigned TheDan64 and airwoodix and unassigned TheDan64 Aug 19, 2024
@TheDan64 TheDan64 added this to the 0.6.0 milestone Aug 19, 2024
@TheDan64
Copy link
Owner

Changes look good to me but tests are not passing

@airwoodix
Copy link
Contributor Author

airwoodix commented Aug 19, 2024

I was a bit fast reading the changelog for v2.0.0 in install-llvm-action. The API changes are not breaking the use here. However, support for LLVM < 7.1 was dropped in KyleMayes/install-llvm-action#64. The limitation seems to come from older releases not being served in the llvm/llvm-project releases.

  • 7734b55 removes LLVM 4-6 from the testing matrix and bumps to 7.1 for the 7 series. Would this be acceptable?
  • f8f9729 reverts to using ubuntu-20.04 (still shipping with libtinfo5, unlike more recent releases) for LLVM 18.

@TheDan64
Copy link
Owner

Maybe we could run the old version for <7 and the new one for newer versions?

@airwoodix
Copy link
Contributor Author

Done in a25308b.

uses apparently doesn't support (ternary) expressions, so the "Install LLVM and Clang" step is duplicated, with exclusive pre-conditions.

Copy link
Owner

@TheDan64 TheDan64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheDan64 TheDan64 merged commit a4e37ac into TheDan64:master Aug 22, 2024
18 checks passed
@airwoodix airwoodix deleted the ci-llvm18 branch August 22, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants