Fix rustc and clippy warnings #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the PR and fix broken tests |
TheDan64
reviewed
May 13, 2024
| @@ -339,6 +341,7 @@ impl ContextImpl { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(deprecated)] | |||
| fn metadata_string<'ctx>(&self, string: &str) -> MetadataValue<'ctx> { | |||
TheDan64
reviewed
May 13, 2024
TheDan64
requested changes
May 13, 2024
TheDan64
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix rustc and clippy warnings, mostly automated with
cargo clippy --fix.How This Has Been Tested
cargo clippy --all-targetson the latest few LLVM versions.Checklist