Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build kaleidoscope in ci and revise example docs #466

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

xieyuschen
Copy link
Contributor

The command provided to run example is not valid in my desktop even though I installed the llvm already:

$ uname -a
Darwin GF9534F26Q 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:41 PST 2021; 
root:xnu-8019.61.5~1/RELEASE_ARM64_T6000 arm64

$ llvm-config  --version
16.0.6

A part of error log is shown below:

➜  inkwell git:(improve/revise-example-guides) cargo run --example kaleidoscope        
   Compiling inkwell v0.2.0 (/Users/yuchen.xie/workspace/rust/inkwell)
error: One of the LLVM feature flags must be provided: llvm4-0 llvm5-0 llvm6-0 llvm7-0 llvm8-0 llvm9-0 llvm10-0 llvm11-0 llvm12-0 llvm13-0 llvm14-0 llvm15-0 llvm16-0 llvm17-0 
   --> src/lib.rs:101:9
    |
101 |           compile_error!(concat!("One of the LLVM feature flags must be provided: ", $($all, " "),*));
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
112 | / assert_unique_used_features! {
113 | |     "llvm4-0",
114 | |     "llvm5-0",
115 | |     "llvm6-0",
...   |
126 | |     "llvm17-0"
127 | | }
    | |_- in this macro invocation
    |
    = note: this error originates in the macro `assert_used_features` which comes from the expansion of the macro `assert_unique_used_features` (in Nightly builds, run with -Z macro-backtrace for more info)

Description

The readme should provide a command which could run the demo directly without any additional exploring. Hence, I changed the readme to cargo run with the llvm version.

Moreover, I change the ci configuration to check build example as well.

@xieyuschen
Copy link
Contributor Author

Hi @TheDan64 , could you kindly review it if you have time. It's a simple change:)

Copy link
Owner

@TheDan64 TheDan64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheDan64 TheDan64 merged commit f5f39bf into TheDan64:master Jan 27, 2024
16 checks passed
@TheDan64 TheDan64 added this to the 0.4.0 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants