Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pub(crate) fn new constructors for value types #457

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

corbanvilla
Copy link
Contributor

Description

Exposing these constructors is helpful when working with LLVM code which isn't yet part of the C-API.

Related Issue

Checklist

@TheDan64
Copy link
Owner

@corbanvilla The newly pub fns need doc comments. Also, Value::new should not be pub since it is internal. Once those are fixed we can merged this

@corbanvilla
Copy link
Contributor Author

@TheDan64 apologies for the delay, just added doc comments!

@TheDan64
Copy link
Owner

@corbanvilla there appear to be some merge conflicts that need to be resolved

@corbanvilla
Copy link
Contributor Author

@TheDan64 Could you clarify where you're referring to.... it looks up to date under the files changed tab.

@TheDan64
Copy link
Owner

For some reason I see
image

@TheDan64
Copy link
Owner

ah okay it looks like I can do a regular merge instead of a rebase...

@TheDan64 TheDan64 merged commit c044e3c into TheDan64:master Feb 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants