Replace parking_lot with the standard library #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically parking_lot's locking types performed better, but since a few Rust releases ago the types provided by the standard library perform well enough. Replacing parking_lot also reduces the number of dependencies. See #419 for more details.
yorickpeterse
commented
Sep 8, 2023
| @@ -167,32 +167,32 @@ impl Target { | |||
| }; | |||
|
|
|||
| if config.base { | |||
| let _guard = TARGET_LOCK.write(); | |||
| let _guard = TARGET_LOCK.write().unwrap_or_else(|e| e.into_inner()); | |||
There was a problem hiding this comment.
I suppose this technically could be left as-is (i.e. without the unwrap), but I'm not a fan of just ignoring Result types.
TheDan64
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Historically parking_lot's locking types performed better, but since a few Rust releases ago the types provided by the standard library perform well enough. Replacing parking_lot also reduces the number of dependencies.
This fixes #419.
Related Issue
#419
How This Has Been Tested
By running
cargo test --features llvm16-0and the equivalentcargo checkcommand.Checklist