Changed std::string to std::filesystem::path in the Filewatcher #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::filesystem::path is used when loading assemblies, so it makes more sense to use this for the filewatcher too, instead of converting a filesystem::path to std::string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue (if no issue has been made)
std::filesystem::path is used when loading assemblies, so it makes more sense to use this for the filewatcher too, instead of converting a std::filesystem::path to std::string. This is natively supported by the library.
Also see: https://github.com/ThomasMonkman/filewatch#4
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:
Proposed fix _(Make sure you've read [on how to contribute]
Changed the occurences of std::string to std::filesystem::path where the filewatcher is concerned. Although std::string is used in other places, this didn't involve the filewatcher and have been left as is.
Additional context
Tested if it still works, which it should since this is not really a breaking change and is supported by the library.
Worked fine when changing a file in the sandbox project and recompiling while running.