Fixes early crash in RenderCommand.cpp (#574) #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue (if no issue has been made)
RendererAPI creation in
RenderCommand.cppwill crash if we try to log something inRendererAPI::Create()function (See #574).PR impact
List of related issues/PRs this will solve:
Proposed fix
Instead of initializing RendererAPI with Create() function, we first initialize it with
nullptr, then we actually create it inRenderCommand::Init()when Hazel's Log system is available.Additional context
statics should not be initialized by calling the program's other system, since that system may not be available at that point.In this situation, a call to
RendererAPI::Create()was made during the (static) initialization phase, which may cause trouble if that function continues to call to other not yet available system.