Replace ftime by gettimeofday for MiNT #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th-otto
force-pushed
the
PR-5
branch
2 times, most recently
from
bb22d78
to
3043fc6
Compare
OmniBlade
approved these changes
Mar 24, 2024
ftime() is an obsolete interface, and <sys/timeb.h> may not be present on all platforms. Also, multiplying a time_t by 1000 will overflow the range of an unsigned 32-bit int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was initially fixed for MiNT, where ftime() is available, but always set the millisec to 0. Avoiding ftime() alltogether should also fix #927