Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converts TD to using Pipe/Straw for save games. #715

Open
wants to merge 1 commit into
base: vanilla
Choose a base branch
from
Open

Converts TD to using Pipe/Straw for save games. #715

wants to merge 1 commit into from

Conversation

OmniBlade
Copy link
Contributor

No description provided.

@OmniBlade OmniBlade mentioned this pull request Dec 17, 2021
Closed
@OmniBlade OmniBlade force-pushed the cleanup/td_save_load branch 2 times, most recently from bf3d4ce to 2620153 Compare June 29, 2022 13:31
@OmniBlade OmniBlade mentioned this pull request Jul 22, 2022
Closed
@MLipfert1 MLipfert1 mentioned this pull request Jul 22, 2022
Closed
@MLipfert1
Copy link
Contributor

I tested your commits on macOS and it works very well. All TD and RA savegames are loaded, saved and delete without problems. The savegame path is correctly set to the user path. 👍

@MLipfert1 MLipfert1 mentioned this pull request Aug 5, 2022
Merged
@MLipfert1
Copy link
Contributor

Is there a chance to get this commit approved soon? It is necessary to load and save Tiberian Dawn savegames on macOS (maybe also Linux) successfully. I have it integrated into my own fork and I am using it for weeks without any issues. This is the last missing piece to get a fully working version of Tiberian Dawn for macOS. ;-)

@OmniBlade
Copy link
Contributor Author

@MLipfert1 Another PR was merged that just cleaned up the saveload code which I think should be sufficient to make macOS support work correctly if you want to check if vanilla works out of the box now.

@MLipfert1
Copy link
Contributor

@OmniBlade
The other PR works also fine for me. 👍 So no urgent need to merge this one here anymore.

@OmniBlade
[TD] Updates Save/Load code to use Pipe/Straw system.
ac3ce7d 
Adds LCW compression and SHA1 checksum.
Uses CDFileClass to ensure files are saved/loaded to/from user data folder.
Adds prefix for side to save/load menu items similar to RA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hifi hifi Awaiting requested review from hifi

@giulianobelinassi giulianobelinassi Awaiting requested review from giulianobelinassi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmniBlade @MLipfert1