Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GRT a separate step #127

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

mleonowicz
Copy link
Contributor

This PR introduces grt as a separate stage from route.

Now, stages may have multiple source stages instead of only one. This was needed, as the new route stage needs both congestion.rpt file, which comes from the grt route, and 4_cts.sdc file, which is produced by a cts stage.

Attaching before and after outputs produced by:
bazel query "deps(//:L1MetadataArray_generate_abstract)" --output=graph --noimplicit_deps --notool_deps > graph && xdot graph

before
after

@oharboe oharboe self-requested a review September 3, 2024 15:59
Copy link
Collaborator

@oharboe oharboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Set GENERATE_ARTIFACTS_ON_FAILURE=1 variable for all stages in ORFS. This will set ORFS into a mode where it creates an artifact for a failed operation, such as ORFS so that e.g. a global route failure artifacts can be downloaded and studied.
  • Rebase on main

@mleonowicz
Copy link
Contributor Author

mleonowicz commented Sep 4, 2024

To support passing GENERATE_ARTIFACTS_ON_FAILURE = 1 argument to all stages, I have added a new argument to orfs_flow called common_args.

I have also rebased the branch.
@oharboe

@oharboe oharboe merged commit ab6136f into The-OpenROAD-Project:main Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants