delta_debug: reduce review noise by getting some simple formatting changes in #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges in Co-authored-by: Øyvind Harboe <[email protected]> Signed-off-by: Øyvind Harboe <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
so that commits won't dither back and forth between locally configured styles Signed-off-by: Øyvind Harboe <[email protected]>
|
@maliberty Picked some formatting rules as a starting point. Fairly forgiving, can be tightened. Only one "flake8 ." error now(a bit tricky to fix because it has to do with mocking and imports, so beyond this PR). |
|
@habibayassin FYI |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I would pick black over yapf. flake8 is fine. |
Sounds good to me, I havent used it. Could you institute it? |
|
@maliberty Instituting black makes this PR moot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broke out some changes from #5223 top make review easier.
@maliberty We need to pick some Python code formatting standard and add that to the repository, otherwise "format source code" is going to give different results depending on locally configured Python IDE...