-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/astro2 #224
Draft
keegansmith21
wants to merge
44
commits into
main
Choose a base branch
from
feature/astro2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/astro2 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegansmith21
force-pushed
the
feature/astro2
branch
2 times, most recently
from
July 29, 2024 02:09
c1349eb
to
bb1da0c
Compare
jdddog
requested changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Keegan, the changes are looking really good, it is much tidier and easier to read the Airflow workflow now that the tasks are split into their own file. I've left a few comments about things that could potentially be refined.
...bservatory-workflows/academic_observatory_workflows/crossref_metadata_telescope/telescope.py
Outdated
Show resolved
Hide resolved
...bservatory-workflows/academic_observatory_workflows/crossref_metadata_telescope/telescope.py
Outdated
Show resolved
Hide resolved
...bservatory-workflows/academic_observatory_workflows/crossref_metadata_telescope/telescope.py
Outdated
Show resolved
Hide resolved
...bservatory-workflows/academic_observatory_workflows/crossref_metadata_telescope/telescope.py
Outdated
Show resolved
Hide resolved
...bservatory-workflows/academic_observatory_workflows/crossref_metadata_telescope/telescope.py
Outdated
Show resolved
Hide resolved
...bservatory-workflows/academic_observatory_workflows/crossref_metadata_telescope/telescope.py
Outdated
Show resolved
Hide resolved
...bservatory-workflows/academic_observatory_workflows/crossref_metadata_telescope/telescope.py
Outdated
Show resolved
Hide resolved
...bservatory-workflows/academic_observatory_workflows/crossref_metadata_telescope/telescope.py
Outdated
Show resolved
Hide resolved
keegansmith21
force-pushed
the
feature/astro2
branch
from
August 21, 2024 07:04
ed50300
to
118cbf9
Compare
keegansmith21
force-pushed
the
feature/astro2
branch
from
September 30, 2024 01:16
a34679d
to
ce14994
Compare
keegansmith21
force-pushed
the
feature/astro2
branch
from
October 16, 2024 05:19
51e2303
to
67e64c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.