INF-572 : query formatting / linting and minor refactoring #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianTonti
commented
Nov 30, 2022
JulianTonti
commented
- export_unique_list - formatting only
- export_relations - formatting only
- export_output_types - formatting only
- export_metrics - formatting only
- export_events - formatting only
- export_dois - formatting and one suggestion
- export_disciplines - formatting only
- export_access_types - formatting only
- create_wos - formatting only
- create_unpaywall -
- refactored repositories sub-query
- replaced binary CASEs with IFs
- replaced other_platform_categories CASE with COUNTIF
- create_unpaywall_repo_names - switched to IFNULL
- create_scopus - formatting only
- create_ror - formatting only
- create_orcid - formatting only
- create_openalex - formatting only
- create_open_citations - fully refactored query
- create_mag - formatting, switched one IF for IFNULL
- create_doi -
- switched IFs for IFNULLs
- one query on count field
- added consistent use of CASTs
- formatting
- create_crossref_fundref - formatting only
- create_crossref_events - formatting only
- create_book - refactored JavaScript UDF and added tests
- create_aggregate - formatting only
- comparison_view - formatting only
* export_unique_list - formatting only * export_relations - formatting only * export_output_types - formatting only * export_metrics - formatting only * export_events - formatting only * export_dois - formatting and one suggestion * export_disciplines - formatting only * export_access_types - formatting only * create_wos - formatting only * create_unpaywall - * refactored repositories sub-query * replaced binary CASEs with IFs * replaced other_platform_categories CASE with COUNTIF * create_unpaywall_repo_names - switched to IFNULL * create_scopus - formatting only * create_ror - formatting only * create_orcid - formatting only * create_openalex - formatting only * create_open_citations - fully refactored query * create_mag - formatting, switched one IF for IFNULL * create_doi - * switched IFs for IFNULLs * one query on count field * added consistent use of CASTs * formatting * create_crossref_fundref - formatting only * create_crossref_events - formatting only * create_book - refactored JavaScript UDF and added tests * create_aggregate - formatting only * comparison_view - formatting only
jdddog
requested changes
Dec 2, 2022
There was a problem hiding this comment.
Thanks for tidying up the SQL Julian, it is much clearer.
What tool are you using for formatting the SQL? It would be good to standardise our approach so that when others are working on the same files we keep the same formatting.
The unit tests for the DOI Workflow are failing which need to be fixed before we merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.