Skip to content

Commit

Permalink
fix(core): add guard check for disposing simple planes
Browse files Browse the repository at this point in the history
  • Loading branch information
agviegas committed Oct 24, 2024
1 parent 26313eb commit ca1ef1f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@thatopen/components",
"description": "Collection of core functionalities to author BIM apps.",
"version": "2.3.11",
"version": "2.3.12",
"author": "That Open Company",
"contributors": [
"Antonio Gonzalez Viegas (https://github.com/agviegas)",
Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/core/Clipper/src/simple-plane.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ export class SimplePlane implements Disposable, Hideable {
* @param {boolean} state - The new enabled state.
*/
set enabled(state: boolean) {
if (this.world.isDisposing) {
return;
}
if (!this.world.renderer) {
throw new Error("No renderer found for clipping plane!");
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/core/Components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class Components implements Disposable {
/**
* The version of the @thatopen/components library.
*/
static readonly release = "2.3.11";
static readonly release = "2.3.12";

/** {@link Disposable.onDisposed} */
readonly onDisposed = new Event<void>();
Expand Down

0 comments on commit ca1ef1f

Please sign in to comment.