Fix sporadic NoMatches error reported from Header on app shutdown #4817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During application shutdown, particularly when running via
App.run_test()
, it seems that the Header's watcher callback ontitle
orsub_title
is called while the Header's children, such as theHeaderTitle
, are already unmounted. This results in aNoMatches
error being raised.We fix this by ignoring the
NoMatches
error, like we did withNoScreen
in the recent "hardening" commit 604b04d.Please review the following checklist.