Feature/#1 #2
Merged
Feature/#1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansolnoh95
requested review from
snowedev,
YoonAh-dev,
seohyun-106 and
hwangJi-dev
|
나는 스크롤노드에 레이아웃 안보이는거 각 컴포넌트들 크기 안잡아줄 때 안보였거든 (특히 컬렉션노드 같은거) 그래서 flexGrow나 flexShrink 값 주거나 maxSize같은거 주고 나서 보였어 혹시 도움이 될까해서 남깁니당 |
YoonAh-dev
approved these changes
Sep 30, 2021
Comment on lines
+149
to
+154
| cardImageNode.style.spacingAfter = 26 | ||
| titleLabelNode.style.spacingAfter = 2 | ||
| priceLabelNode.style.spacingAfter = 13 | ||
| barcodeImageNode.style.spacingAfter = 6 | ||
| cardNumberTextNode.style.spacingAfter = 8 | ||
| validationLayoutSpec().style.spacingAfter = 33 |
There was a problem hiding this comment.
간격을 따로 줄 수 있더라구여,,, 되기만 하면 아주 편할 거 같은데 말이져 ㅎ;
hwangJi-dev
approved these changes
Sep 30, 2021
snowedev
approved these changes
Sep 30, 2021
그런거여꾼,,, 다들 preferredSize나 width, height, flexShrink 등등 넣었더라구,, 고쳐보게씀다 감삼다!! |
담주는 꼭 다 부셔서 갈 수 있도록 할게여,,,!! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1
Summary
Sth Coming Newly
카드 쉐도우를 적용하는데 background에서 함수를 실행시킨다면 main Thread 에서 실행해야한다는 에러가 송출되여
Challenges
scrollNode 에 컴포넌트들을 넣는 것이 가장 어려웠고 아직도 해결을 못해씀다,,,
References