Fix(Network): Fix responseSize error when readyState === 3.

Tencent · Mar 24, 2022 · f7b913a · f7b913a
1 parent 6693584
commit f7b913a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 English | [简体中文](./CHANGELOG_CN.md)
 
+## 3.14.1 (2022-03-24)
+
+- `Fix(Network)` Fix `responseSize` error when `readyState === 3`.
+
+
 ## 3.14.0 (2022-03-23)
 
 - `Feat(Core)` Add new option `pluginOrder` to adjust the order of built-in and custom plugins, see [Public Properties & Methods](./doc/public_properties_methods.md).

diff --git a/CHANGELOG_CN.md b/CHANGELOG_CN.md
@@ -1,5 +1,10 @@
 [English](./CHANGELOG.md) | 简体中文
 
+## 3.14.1 (2022-03-24)
+
+- `Fix(Network)` 修复当 `readyState === 3` 时的 `responseSize` 错误。
+
+
 ## 3.14.0 (2022-03-23)
 
 - `Feat(Core)` 新增配置项 `pluginOrder` 来调整插件面板的排序，见 [公共属性及方法](./doc/public_properties_methods_CN.md)。

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vconsole",
-  "version": "3.14.0",
+  "version": "3.14.1",
   "description": "A lightweight, extendable front-end developer tool for mobile web page.",
   "homepage": "https://github.com/Tencent/vConsole",
   "files": [

diff --git a/src/network/helper.ts b/src/network/helper.ts
@@ -106,8 +106,10 @@ export const updateItemByReadyState = (item: VConsoleNetworkRequestItem, XMLReq:
     case 3: // LOADING
       item.status = XMLReq.status;
       item.statusText = 'Loading';
-      item.responseSize = XMLReq.response.length;
-      item.responseSizeText = tool.getBytesText(item.responseSize);
+      if (typeof XMLReq.response === 'object' && XMLReq.response.length) {
+        item.responseSize = XMLReq.response.length;
+        item.responseSizeText = tool.getBytesText(item.responseSize);
+      }
       break;
 
     case 4: // DONE
@@ -117,7 +119,7 @@ export const updateItemByReadyState = (item: VConsoleNetworkRequestItem, XMLReq:
       item.endTime = Date.now(),
       item.costTime = item.endTime - (item.startTime || item.endTime);
       item.response = XMLReq.response;
-      if (XMLReq.response.length) {
+      if (typeof XMLReq.response === 'object' && XMLReq.response.length) {
         item.responseSize = XMLReq.response.length;
         item.responseSizeText = tool.getBytesText(item.responseSize);
       }