Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): dialog中的tabs默认选中样式不正确 #4722

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

chensid
Copy link
Contributor

@chensid chensid commented Nov 11, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

[tabs] dialog中的tabs默认选中样式不正确 #4692

💡 需求背景和解决方案

背景:
dialog 设置destroy-on-close属性后,子组件getBoundingClientRect方法获取不正确。
方案:
useResizeObserver中的debounce的wait值设置为35,略大于2 × 16.67ms ≈ 33.34ms

📝 更新日志

  • fix(tabs): dialog中的tabs默认选中样式不正确

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Nov 12, 2024

完成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant