Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(space): fix redundant space render when using v-if #4663

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Luffy-developer
Copy link
Contributor

@Luffy-developer Luffy-developer commented Oct 16, 2024

修复了在t-space嵌套使用时,如果内层的t-space用v-if判断,条件为false,仍然会生成t-space-item元素,导致样式不正确的问题。

closed #4649

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#4649

💡 需求背景和解决方案

渲染t-space节点中,未过滤掉v-if为false的节点,导致布局中的样式有问题。

📝 更新日志

  • fix(Space): 修复使用v-if的情况下存在冗余空格的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Oct 17, 2024

完成

@uyarn
Copy link
Collaborator

uyarn commented Oct 17, 2024

/update-common

@uyarn
Copy link
Collaborator

uyarn commented Oct 17, 2024

/update-snapshot

Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

@uyarn uyarn changed the title fix(space): 修复t-space存在冗余空格的问题 fix(space): fix redundant space render when using v-if Oct 17, 2024
@uyarn uyarn merged commit 9611e6b into Tencent:develop Oct 17, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 26, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Space] t-space存在冗余空格
2 participants