Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from isopen #34

Closed
wants to merge 21 commits into from
Closed

Update from isopen #34

wants to merge 21 commits into from

Conversation

isopen
Copy link

@isopen isopen commented Oct 23, 2022

  1. 2234562
    load_uint(32) is sure enough for subwallet_id?
    subwallet_id::uint32 -> subwallet_id::uint64
    https://t.me/d_code/15131
    https://t.me/durov/167
  2. cbd5c6d
    Duplicate in readme
  3. eddde78 7aa8c92
    Suggestion to use Security Policy
  4. Approximate analysis README.md #36
  5. d0b95e3 a8c5c5b
    In my opinion, the beginning of the comment is superfluous
  6. 9600401
    508baef
    .tlb schema update
  7. 2a6c32d
    [uint32 -> uint64] in readme
  8. License for common.fc, nft-collection.fc, nft-item.fc, telemint.tlb, README.md #37
    Question about the license
  9. ;; ignore errors in function send_money #39
    Possible desynchronization in operations with toncoin (method send_money)
    Tonkoins did not arrive to the addressee, but the sender's balance changed to a new value.
  10. ebd8f35 f6a87fe fc77e3c
    ddd4cf7 4632549
    Exception refactoring (moved errors to constants)
  11. d35f9c6
    Pointless comment
  12. 4fc9267 409d17b
    In case of negative royalty
  13. eaa710f
    https://github.com/DavidAnson/markdownlint/blob/v0.26.2/doc/Rules.md#md034
  14. Move 1000000000 to a constant #57
    Small refactoring

After the contest:
15. 3611bd0
Made a merge with the main branch to be without conflict. I use a constant err::invalid_length
common.fc::throw_unless(err::invalid_length, i); ;; should not start with \0

@isopen isopen changed the title Update common.fc Update from isopen Oct 23, 2022
@Hhnonk
Copy link

Hhnonk commented Apr 28, 2024

A6

@isopen isopen closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants