ANDROID-15323 Open tweaks as single top #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamal-alm
requested review from
a team,
jeslat and
juangardi21
and removed request for
a team
juangardi21
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
We are exposiing the "open tweaks when shaking" with a
navigateToTweaksOnShakemethod. However if more than one shake is detected multiple tweaks screens are opened and added to the navigation stack, forcing the user to press back several times to exit tweaks .We should open just one instance of tweaks even if multiple shakes are detected.
🚧 How do we do it?
Set
launchSingleToptotruewhen navigating toTWEAKS_NAVIGATION_ENTRYPOINT.📘 Documentation changes?
🧪 How can I test this?
Before
Grabacion.de.pantalla.2024-11-08.a.las.9.47.35.mov
After
Grabacion.de.pantalla.2024-11-08.a.las.9.47.06.mov