Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Room 입장 분기처리 추가 #59

Merged
merged 7 commits into from
Jun 6, 2024
Merged

[fix] Room 입장 분기처리 추가 #59

merged 7 commits into from
Jun 6, 2024

Conversation

kmjenny
Copy link
Contributor

@kmjenny kmjenny commented Jun 5, 2024

Related issue 🛠

Work Description ✏️

  • 분기처리 부분 service에 추가
  • build.gradle 의존성 추가

Copy link
Contributor

@minwoo0419 minwoo0419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@@ -10,6 +10,7 @@
public enum ForbiddenErrorCode implements DefaultErrorCode{

FORBIDDEN(HttpStatus.FORBIDDEN, "error", "접근 권한이 없습니다."),
ENTER_FORBIDDEN(HttpStatus.FORBIDDEN, "error", "이미 매칭이 완료된 방입니다."),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것도 마찬가지로 error가 아닌 conflict인 것같은데 어떻게생각하시나요?

Copy link
Contributor

@tkdwns414 tkdwns414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 부탁드립니다

Copy link
Contributor

@minwoo0419 minwoo0419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict해결 잘해서 머지 부탁드릴게여

@kmjenny kmjenny merged commit e2d1a71 into develop Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Room 입장 분기처리 추가
3 participants