Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 유저 인증 인가 구현 #31

Merged
merged 28 commits into from
May 29, 2024
Merged

[feat] 유저 인증 인가 구현 #31

merged 28 commits into from
May 29, 2024

Conversation

tkdwns414
Copy link
Contributor

@tkdwns414 tkdwns414 commented May 21, 2024

Related issue 🛠

Work Description ✏️

  • 유저 인증 및 인가에 필요한 API들을 제작했습니다.
  • Security는 자체로도 리소스가 커서 따로 분리할 예정입니다.

Uncompleted Tasks 😅

  • 회원 로그인 시 fcm Token 업데이트
  • withdrawal 테스트 코드
  • reissue 테스트 코드
  • @userid 적용

To Reviewers 📢

마감 기한이 얼마 남지 않아 테스트 코드들은 작성하지 않았습니다.
Users entity를 User로 rename 하였습니다.
테스트 코드 작성 중 JwtUtil을 같이 사용하기 위해 @SpringBootTest를 사용했는데 이후 수정하고 싶습니다...

@tkdwns414 tkdwns414 self-assigned this May 21, 2024
@tkdwns414 tkdwns414 requested review from kmjenny and minwoo0419 and removed request for kmjenny May 28, 2024 17:01

@Entity
@Getter
@Table(name="users")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테이블 이름도 user로 바꿔야하지 않나요..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테이블 이름이 user가 예약어라서 테이블명을 바꿔야하는거고 엔티티 명은 그냥 단수 그대로 User로 가는겁니다!

Copy link
Contributor

@kmjenny kmjenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당ᖭི(ˊᗜˋ*)ᖫྀ

Copy link
Contributor

@minwoo0419 minwoo0419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@tkdwns414 tkdwns414 merged commit 74a0f6f into develop May 29, 2024
1 check passed
@tkdwns414 tkdwns414 deleted the feat/24 branch May 29, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 유저 인증 인가 구현
3 participants